Quantcast
Channel: feedbackd:2ca7a329b7eb368073c2dddc875eb7d7824575be commits
Viewing all articles
Browse latest Browse all 40

fbd-event: Make sure we iterate the list safely

$
0
0
When all feedbacks are done the event signals "feedbacks-ended" which lets the manager dispose the feedback. When all feedbacks end instantly and synchronously (as is the case with the dummy feedback) this triggers the disposal of the event within the loop leading to a crash. Make sure the object doesn't go away be referencing it during the loop iteration. We didn't see this before as glib's slice allocator for lists papered over this for us. Closes: #69

Viewing all articles
Browse latest Browse all 40

Trending Articles